On Tue, Mar 12, 2019 at 4:19 PM Andy Shevchenko <andy.shevche...@gmail.com> wrote: > > On Tue, Mar 12, 2019 at 6:40 AM Masahiro Yamada > <yamada.masah...@socionext.com> wrote: > > On Sun, Mar 3, 2019 at 4:51 PM William Breathitt Gray > > <vilhelm.g...@gmail.com> wrote: > > > > > > Replace verbose implementation in set_multiple callback with > > > for_each_set_clump8 macro to simplify code and improve clarity. An > > > improvement in this case is that banks that are not masked will now be > > > skipped. > > > Please do not do this. > > > > Nothing in this driver says the GPIO width is 8-bit. > > Huh? > > https://elixir.bootlin.com/linux/latest/source/include/dt-bindings/gpio/uniphier-gpio.h#L9 > > Isn't a hardcoding?
Semi-hardcoding. I needed to factor out some magic numbers shared between DT and drivers. Then, dt-bindings is out of realm of operating system. If I am doing wrong, I take back my comments, though. -- Best Regards Masahiro Yamada
