On Tue, Mar 5, 2019 at 3:42 AM Nava kishore Manne <na...@xilinx.com> wrote:
>
> Hi Rob,
>
> Thanks for the quick response.
> Please find my response inline.
>
> > -----Original Message-----
> > From: Rob Herring [mailto:r...@kernel.org]
> > Sent: Monday, March 4, 2019 10:57 PM
> > To: Nava kishore Manne <na...@xilinx.com>
> > Cc: mark.rutl...@arm.com; Michal Simek <mich...@xilinx.com>; Rajan Vaja
> > <raj...@xilinx.com>; linux-arm-ker...@lists.infradead.org; linux-
> > ker...@vger.kernel.org; devicet...@vger.kernel.org; Jolly Shah
> > <jol...@xilinx.com>; chinnikishore...@gmail.com
> > Subject: Re: [PATCH v3 6/6] dt-bindings: fpga: Add bindings for ZynqMP fpga
> > driver
Please fix your mail program to...
> > On Mon, Mar 4, 2019 at 5:35 AM Nava kishore Manne <na...@xilinx.com>
> > wrote:
...use this style reply header.
[...]
> > > Device Tree Example for Full Reconfiguration
> > > ============================================
> > >
> > > Live Device Tree contains:
> > >
> > > zynqmp_pcap: pcap {
> > > compatible = "xlnx,zynqmp-pcap-fpga";
> > > };
> > >
> > > fpga_region0: fpga-region0 {
> >
> > This should be a child of pcap.
> >
> AFAIK we can't put the fpga-region as a child of pcap as both are independent
> and they refered to each other using phandlers
> I have made this changes by looking into the below reference doc.
> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/fpga/fpga-region.txt
Indeed. But having them a as child of the firmware node doesn't make
sense either. Putting them at the top level would make more sense. I
don't recall why we didn't make them a child. Maybe regions can span
multiple bridges in the case with bridges.
> > > compatible = "fpga-region";
> > > fpga-mgr = <&zynqmp_pcap>;
> > > #address-cells = <0x1>;
> > > #size-cells = <0x1>;
> > > ranges;
> > > };
> > >
> > > DT Overlay contains:
> >
> > Don't show overlays in examples. Just show a final tree (i.e. base with
> > overlay
> > applied).
>
> To get a better picture for the users i have added this example node with
> overlays
> I feel it's good to have this info because it will not impact the
> functionality of PCAP node.
Then feel free to document this somewhere else. As we move to schema
documents, your examples will have to compile and validate against the
schema. I don't want to add applying overlays to the mix.
Rob
