On Fri, Mar 15, 2019 at 10:43:42AM +0100, Borislav Petkov wrote: > On Thu, Mar 14, 2019 at 02:59:52PM -0700, Luck, Tony wrote: > > I made a patch based on option #3. Rough steps were: > > > > $ cat skx_common.c >> skx_common.h > > That doesn't look real clean to me. So we have fsl_ddr_edac.c which > gets linked in in two drivers and I think you could librarize that > skx_common.c the same way and have the function exports in the wrapper > drivers skx_edac and i10nm_edac calling those "library" functions in > skx_common.c. IMNSVHO.
fsl_ddr_edac.c looks to be doing exactly what we are doing with skx_common.c. They just get away with it for now because they don't have a reference to THIS_MODULE since they don't set up anything in sysfs. If this is your goal, then Qiuxu's patch that moves the problem piece out of skx_common.c does what you are asking for. -Tony
