On 18/03/2019 21:02, Martin Blumenstingl wrote: > Hi Neil, > > On Mon, Mar 18, 2019 at 10:59 AM Neil Armstrong <[email protected]> > wrote: >> >> Add nodes and properties for the AO Clocks and Resets. >> >> Signed-off-by: Neil Armstrong <[email protected]> >> Signed-off-by: Jerome Brunet <[email protected]> >> --- >> arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi >> b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi >> index 31ddf9444b3e..5c0983edf837 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi >> @@ -4,6 +4,7 @@ >> */ >> >> #include <dt-bindings/gpio/gpio.h> >> +#include <dt-bindings/clock/g12a-clkc.h> >> #include <dt-bindings/interrupt-controller/irq.h> >> #include <dt-bindings/interrupt-controller/arm-gic.h> >> >> @@ -122,6 +123,23 @@ >> #size-cells = <2>; >> ranges = <0x0 0x0 0x0 0xff800000 0x0 0x100000>; >> >> + rti: sys-ctrl@0 { >> + compatible = "amlogic,meson-gx-ao-sysctrl", >> + "simple-mfd", "syscon"; >> + reg = <0x0 0x0 0x0 0x100>; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges = <0x0 0x0 0x0 0x0 0x0 0x100>; > sorry for noticing this only very late: I missed the #address-cells, > #size-cells and ranges property in my last review > do you have any change queued which requires this? > my understanding is that the drivers for all RTI children should use > the register offsets relative to the RTI start address. In that case > the child nodes neither have a unit-address nor a reg property, making > the last three properties unnecessary.
We need the address-cells/size-cells and `ranges;` to satisfy the need for the gpio subnode of the pinctrl node. For GX, we didn't add the pinctrl in the sysctrl_AO subnode, but we should overwise we have overlapping. Neil > > > Regards > Martin >
