Hi, I am sorry for this warning. I remember I checked all changes I
sent, maybe missed this one.
At the bottom the file says
MODULE_LICENSE("GPL");
and
// SPDX-License-Identifier: GPL-2.0
makes it inconsistent.
Regards,
Roman.
On Tue, Mar 19, 2019 at 7:51 AM Thomas Gleixner <t...@linutronix.de> wrote:
>
> spdxcheck.py complains:
>
> drivers/power/supply/goldfish_battery.c: 1:28 Invalid License ID: GPL
>
> which is correct because GPL is not a valid identifier. Of course this
> could have been caught by checkpatch.pl _before_ submitting or merging the
> patch.
>
> WARNING: 'SPDX-License-Identifier: GPL' is not supported in LICENSES/...
> #19: FILE: drivers/power/supply/goldfish_battery.c:1:
> +// SPDX-License-Identifier: GPL
>
> Which is absolutely hillarious as the commit introducing this wreckage says
> in the changelog:
>
> There was a checkpatch complain:
>
> "Missing or malformed SPDX-License-Identifier tag".
>
> Oh well. Replacing a checkpatch warning by a different checkpatch warning
> is a really useful exercise.
>
> Use the proper GPL-2.0 identifier which is what the boiler plate in the
> file had originally.
>
> Fixes: e75e3a125b40 ("drivers: power: supply: goldfish_battery: Put an SPDX
> tag")
> Signed-off-by: Thomas Gleixner <t...@linutronix.de>
> ---
> diff --git a/drivers/power/supply/goldfish_battery.c
> b/drivers/power/supply/goldfish_battery.c
> index ad969d9fc981..c2644a9fe80f 100644
> --- a/drivers/power/supply/goldfish_battery.c
> +++ b/drivers/power/supply/goldfish_battery.c
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * Power supply driver for the goldfish emulator
> *
