A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply?
On Tue, 19 Mar 2019, Roman Kiryanov wrote: > Hi, I am sorry for this warning. I remember I checked all changes I > sent, maybe missed this one. > > At the bottom the file says > > MODULE_LICENSE("GPL"); > > and > > // SPDX-License-Identifier: GPL-2.0 > > makes it inconsistent. No. It does not. 1) The module license is not a precise license indicator. 2) SPDX License identifiers are well defined and standardized. 'GPL' is NOT a valid SPDX identifier. The usage of SPDX identifiers and the relevance of the MODULE_LICENSE() string are well documented in: Documentation/process/license-rules.rst or for your conveniance at: https://www.kernel.org/doc/html/latest/process/license-rules.html Thanks, tglx