On Fri 22-03-19 12:20:12, Souptick Joarder wrote: > On Thu, Mar 21, 2019 at 2:13 AM Qian Cai <c...@lca.pw> wrote: > > > > When start_isolate_page_range() returned -EBUSY in __offline_pages(), it > > calls memory_notify(MEM_CANCEL_OFFLINE, &arg) with an uninitialized > > "arg". As the result, it triggers warnings below. Also, it is only > > necessary to notify MEM_CANCEL_OFFLINE after MEM_GOING_OFFLINE. > > For my clarification, if test_pages_in_a_zone() failed in __offline_pages(), > we have the similar scenario as well. If yes, do we need to capture it > in change log ?
Yes this is the same situation. We can add a note that the same applies to test_pages_in_a_zone failure path but I do not think it is strictly necessary. Thanks for the note anyway. -- Michal Hocko SUSE Labs
