Hi Lee Jones, Can you review this patch?
Thanks. > On Mar 9, 2019, at 2:04 AM, Kangjie Lu <k...@umn.edu> wrote: > > In case devm_kzalloc fails, the fix does NULL check and returns > -ENOMEM upon failure so as to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu <k...@umn.edu> > --- > drivers/mfd/sm501.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c > index a530972c5a7e..e0173bf4b0dc 100644 > --- a/drivers/mfd/sm501.c > +++ b/drivers/mfd/sm501.c > @@ -1145,6 +1145,9 @@ static int sm501_register_gpio_i2c_instance(struct > sm501_devdata *sm, > lookup = devm_kzalloc(&pdev->dev, > sizeof(*lookup) + 3 * sizeof(struct gpiod_lookup), > GFP_KERNEL); > + if (!lookup) > + return -ENOMEM; > + > lookup->dev_id = "i2c-gpio"; > if (iic->pin_sda < 32) > lookup->table[0].chip_label = "SM501-LOW"; > -- > 2.17.1 >
