On Mon, Mar 25, 2019 at 01:25:50PM +0800, Alan Kao wrote: > Hi Anup, > > Sorry for being late to the party. I think one more thing should > move together with setup_vm():
Ah, I wonded about that yesterday but wasn't sure. Maybe notrace is a little cleaner? Either way we should probably document both the mcmodel and notrace assumptions in source comments for the next person touching this code.