Hi Stephen, Thank you for these patches,
Could you check them through with PEP8 please? While we are not entirely "pep8 clean", Your series adds the following warnings: linux/config.py:10:1: E302 expected 2 blank lines, found 1 linux/config.py:17:41: E128 continuation line under-indented for visual indent linux/config.py:30:9: E722 do not use bare 'except' linux/config.py:35:41: E128 continuation line under-indented for visual indent linux/config.py:40:9: E722 do not use bare 'except' linux/config.py:48:1: E305 expected 2 blank lines after class or function definition, found 1 linux/rbtree.py:18:17: E128 continuation line under-indented for visual indent linux/rbtree.py:29:1: E302 expected 2 blank lines, found 1 linux/rbtree.py:34:17: E128 continuation line under-indented for visual indent linux/rbtree.py:45:1: E302 expected 2 blank lines, found 1 linux/rbtree.py:49:1: E302 expected 2 blank lines, found 1 linux/rbtree.py:52:1: E302 expected 2 blank lines, found 1 linux/rbtree.py:57:17: E128 continuation line under-indented for visual indent linux/rbtree.py:75:1: E302 expected 2 blank lines, found 1 linux/rbtree.py:80:17: E128 continuation line under-indented for visual indent linux/rbtree.py:115:1: E305 expected 2 blank lines after class or function definition, found 1 linux/rbtree.py:117:1: E302 expected 2 blank lines, found 1 linux/rbtree.py:133:1: E305 expected 2 blank lines after class or function definition, found 1 linux/rbtree.py:135:1: E302 expected 2 blank lines, found 1 linux/rbtree.py:151:1: E305 expected 2 blank lines after class or function definition, found 1 linux/rbtree.py:153:1: E302 expected 2 blank lines, found 1 linux/rbtree.py:169:1: E305 expected 2 blank lines after class or function definition, found 1 linux/timerlist.py:26:1: E302 expected 2 blank lines, found 1 linux/timerlist.py:27:80: E501 line too long (95 > 79 characters) linux/timerlist.py:28:80: E501 line too long (85 > 79 characters) linux/timerlist.py:37:80: E501 line too long (81 > 79 characters) linux/timerlist.py:38:13: E128 continuation line under-indented for visual indent linux/timerlist.py:41:1: E302 expected 2 blank lines, found 1 linux/timerlist.py:50:1: E302 expected 2 blank lines, found 1 linux/timerlist.py:63:1: E302 expected 2 blank lines, found 1 linux/timerlist.py:81:12: E122 continuation line missing indentation or outdented linux/timerlist.py:82:12: E122 continuation line missing indentation or outdented linux/timerlist.py:83:12: E122 continuation line missing indentation or outdented linux/timerlist.py:84:12: E122 continuation line missing indentation or outdented linux/timerlist.py:85:12: E122 continuation line missing indentation or outdented linux/timerlist.py:103:12: E122 continuation line missing indentation or outdented linux/timerlist.py:104:12: E122 continuation line missing indentation or outdented linux/timerlist.py:105:12: E122 continuation line missing indentation or outdented linux/timerlist.py:106:12: E122 continuation line missing indentation or outdented linux/timerlist.py:107:12: E122 continuation line missing indentation or outdented linux/timerlist.py:108:12: E122 continuation line missing indentation or outdented linux/timerlist.py:109:12: E122 continuation line missing indentation or outdented linux/timerlist.py:110:12: E122 continuation line missing indentation or outdented linux/timerlist.py:111:12: E122 continuation line missing indentation or outdented linux/timerlist.py:112:12: E122 continuation line missing indentation or outdented linux/timerlist.py:113:12: E122 continuation line missing indentation or outdented linux/timerlist.py:114:12: E122 continuation line missing indentation or outdented linux/timerlist.py:115:12: E122 continuation line missing indentation or outdented linux/timerlist.py:116:12: E122 continuation line missing indentation or outdented linux/timerlist.py:122:1: E302 expected 2 blank lines, found 1 linux/timerlist.py:150:15: E124 closing bracket does not match visual indentation linux/timerlist.py:160:1: E302 expected 2 blank lines, found 1 linux/timerlist.py:183:65: E261 at least two spaces before inline comment linux/timerlist.py:183:80: E501 line too long (88 > 79 characters) linux/timerlist.py:186:77: E261 at least two spaces before inline comment linux/timerlist.py:186:80: E501 line too long (100 > 79 characters) linux/timerlist.py:190:80: E501 line too long (125 > 79 characters) linux/timerlist.py:194:1: E305 expected 2 blank lines after class or function definition, found 1 -- Regards Kieran On 25/03/2019 18:45, Stephen Boyd wrote: > This is a handful of changes to the kernel's gdb scripts to do some more > debugging with kgdb. The first patch allows the vmlinux to be reloaded > from where it was specified on the command line so that this set of > scripts can be used from anywhere. The second patch adds a script to > dump the config.gz to a file on the host debugging machine. The third > patch adds some rb tree utilities and the last patch uses those rb tree > walking utilities to dump out the contents of /proc/timer_list from a > system under debug. > > I'm guessing that Andrew will pick these patches up. I don't know who > maintains these gdb scripts but it looks like Andrew has been doing the > lifting recently. > > Cc: Douglas Anderson <[email protected]> > Cc: Nikolay Borisov <[email protected]> > Cc: Kieran Bingham <[email protected]> > Cc: Jan Kiszka <[email protected]> > Cc: Jackie Liu <[email protected]> > > Stephen Boyd (4): > scripts/gdb: Find vmlinux where it was before > scripts/gdb: Add kernel config dumping command > scripts/gdb: Add rb tree iterating utilities > scripts/gdb: Add a timer list command > > scripts/gdb/linux/config.py | 48 ++++++++ > scripts/gdb/linux/constants.py.in | 8 ++ > scripts/gdb/linux/rbtree.py | 169 ++++++++++++++++++++++++++ > scripts/gdb/linux/symbols.py | 6 +- > scripts/gdb/linux/timerlist.py | 194 ++++++++++++++++++++++++++++++ > scripts/gdb/vmlinux-gdb.py | 3 + > 6 files changed, 427 insertions(+), 1 deletion(-) > create mode 100644 scripts/gdb/linux/config.py > create mode 100644 scripts/gdb/linux/rbtree.py > create mode 100644 scripts/gdb/linux/timerlist.py > > > base-commit: 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b > -- -- Kieran
