On Thu, Apr 4, 2019 at 2:12 AM Daniel Lezcano <[email protected]> wrote: > > On 01/04/2019 06:14, Andrey Smirnov wrote: > > Expose thermal readings as a HWMON device, so that it could be > > accessed using lm-sensors. > > > > Signed-off-by: Andrey Smirnov <[email protected]> > > Cc: Chris Healy <[email protected]> > > Cc: Lucas Stach <[email protected]> > > Cc: Zhang Rui <[email protected]> > > Cc: Eduardo Valentin <[email protected]> > > Cc: Daniel Lezcano <[email protected]> > > Cc: Angus Ainslie (Purism) <[email protected]> > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > --- > > drivers/thermal/qoriq_thermal.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/thermal/qoriq_thermal.c > > b/drivers/thermal/qoriq_thermal.c > > index 9d227654f879..7fb9321a0d8c 100644 > > --- a/drivers/thermal/qoriq_thermal.c > > +++ b/drivers/thermal/qoriq_thermal.c > > @@ -12,6 +12,7 @@ > > #include <linux/thermal.h> > > > > #include "thermal_core.h" > > +#include "thermal_hwmon.h" > > > > #define SITES_MAX 16 > > > > @@ -103,7 +104,10 @@ static int qoriq_tmu_register_tmu_zone(struct device > > *dev, > > case -ENODEV: > > continue; > > case 0: > > - break; > > + ret = devm_thermal_add_hwmon_sysfs(tzd); > > + if (!ret) > > + break; > > + /* fallthrough */ > > Do we really want to disable the thermal zone if the hwmon fails to > register ?
Original code already disables all thermal zones if any single one fails to register, so I though we may as well be as strict for hwmon registration as well. Doesn't have to be though. Will change in v4. Thanks, Andrey Smirnov
