Sven Schnelle wrote:
While implementing kprobes on PA-RISC (without kretprobes) compilation
fails when CONFIG_KPROBE_EVENTS is enabled:
Thanks for working on that! Is there a specific reason kretprobes is not
being enabled on parisc?
kernel/trace/trace_kprobe.o: in function `trace_kprobe_create':
kernel/trace/trace_kprobe.c:666: undefined reference to `kprobe_on_func_entry'
kernel/trace/trace_kprobe.o: in function `trace_kprobe_on_func_entry':
kernel/trace/trace_kprobe.c:167: undefined reference to `kprobe_on_func_entry'
kernel/trace/trace_kprobe.c:167: undefined reference to `kprobe_on_func_entry'
make: *** [Makefile:1029: vmlinux] Error 1
Given the fact that these functions have no dependencies on kretprobes i think
they should be moved out of the #ifdef CONFIG_KRETPROBES block.
Signed-off-by: Sven Schnelle <[email protected]>
Cc: "Naveen N. Rao" <[email protected]>
Cc: Anil S Keshavamurthy <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
---
kernel/kprobes.c | 39 ++++++++++++++++++++-------------------
1 file changed, 20 insertions(+), 19 deletions(-)
These functions were originally added only for kretprobes, but have
taken on newer uses since then. So, for this patch:
Acked-by: Naveen N. Rao <[email protected]>
However, I wonder if we should simply remove CONFIG_KRETPROBES
altogether. All architectures supporting kprobes today also support
kretprobes. I don't see why anyone would want to only disable
kretprobes.
- Naveen
