Quoting Russell King - ARM Linux admin (2019-04-09 01:57:17) > On Tue, Apr 09, 2019 at 05:31:48AM +0000, Vaittinen, Matti wrote: > > On Mon, 2019-04-08 at 23:21 +0100, Russell King - ARM Linux admin > > wrote: > > > On Mon, Apr 08, 2019 at 10:00:02AM -0700, Stephen Boyd wrote: > > > > > > > > > > > > > Sure. I was thinking along the same lines after you asked. > > > > > > This is rubbish. The reason clk_find() doesn't take the lock is that > > > you _need_ to hold the lock while you dereference the clk_lookup > > > data. > > > > I think we all agreed on this already. Stephen pointed out that the > > current user(s) of clk_find() do _not_ dereference the pointer. > > Which is actually another incorrect statement - clk_get_sys() > dereferences it, but Stephen's patch does rearrange the code there. >
I've split this patch into two. One to fix the locking of the new clk_find() user and the other to introduce a clk_find_hw() API that lets me use it later on in this series. I'll resend the series with this update.
