Hi, From: Sudeep Holla [[email protected]]: > static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd) > { > + if ((reboot_mode == REBOOT_WARM || reboot_mode == REBOOT_SOFT) &&
I would omit the REBOOT_SOFT here. > + psci_system_reset2_supported) > + /* > + * reset_type[31] = 0 (architectural) > + * reset_type[30:0] = 0 (SYSTEM_WARM_RESET) > + * cookie = 0 (ignored by the implementation) > + */ > + invoke_psci_fn(PSCI_FN_NATIVE(1_1, SYSTEM_RESET2), 0, 0, 0); > + > invoke_psci_fn(PSCI_0_2_FN_SYSTEM_RESET, 0, 0, 0); Use else here, so that we fall back to system halt if SYSTEM_RESET2 fails. A.
