Re: [PATCH v2 1/2] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

[Andrew Lunn]

> +     mdio {
> +             #address-cells = <1>;
> +             #size-cells = <0>;
> +
> +             ethphy0: ethernet-phy@1 {
> +                     compatible = "ethernet-phy-ieee802.3-c22";

Hi Angus

This compatible string is optional. It won't warm, but it is not
needed.

> +                     reg = <1>;
> +                     power-supply = <&reg_3V3_P>;

I don't remember seeing a power-supply property in an Ethernet PHY
node before. What is using it? The PHY driver? Or the driver core
code?

        Andrew