Hi Neil, On Fri, Apr 12, 2019 at 12:05 PM Neil Armstrong <narmstr...@baylibre.com> wrote: > > Amlogic G12A SoCs uses the exact same IR decoder as previous > families, add the IR node and the pintctrl setting. as far as I can tell there are either two IR decoders or one updated IR decoder in G12A and G12B. I'm using mesong12a.dtsi from buildroot_openlinux_kernel_4.9_fbdev_20180706 as reference: remote:rc@0xff808040 { compatible = "amlogic, aml_remote"; reg = <0x0 0xff808040 0x00 0x44>, /*Multi-format IR controller*/ <0x0 0xff808000 0x00 0x20>; /*Legacy IR controller*/ ...
the registers which you are mapping are for the "Legacy IR controller", so our existing meson-ir driver will probably work (I haven't tested it myself yet). can you please be explicit about this in the patch description? > Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> apart from the description you can add my: Reviewed-by: Martin Blumenstingl<martin.blumensti...@googlemail.com>