On Mon, Apr 15, 2019 at 03:10:02PM +0200, Johan Hovold wrote: > On Fri, Apr 05, 2019 at 03:14:37PM -0500, Madhumitha Prabakaran wrote: > > Fix a blank line after function/struct/union/enum > > declarations. Also, convert to_gb_control() macro into an inline > > function in order to maintain Linux kernel coding style based > > on which the inline function is preferable over the macro. > > There are about 1200 macros wrapping container_of() in the kernel, so > this is a common pattern which does not need to be changed (by contrast, > only a handful container_of are wrapped by functions). >
A handful? $ git grep "return container_of" | wc -l 1856 I'm like Donald Trump because I must have really small hands compared to the rest of y'all. I would prefer to apply these sorts of patches unless it causes an issue... Functions *are* better than macros. It's a minor improvement, but this is staging and we make tons minor style changes. It's part of the blessing and curse of being in staging... regards, dan carpenter
