On Wed, Apr 17, 2019 at 3:01 AM Borislav Petkov <b...@alien8.de> wrote: > > On Mon, Apr 08, 2019 at 01:58:34PM +0800, Pingfan Liu wrote: > > Beside kernel, at early boot stage, the KASLR code also needs to parse the > > crashkernel=x@y or crashkernel=ramsize-range:size[,...][@offset] option, > > and avoid to put randomized kernel in the region. > > > > Extracting the parsing related routines to lib/parse_crashkernel.c, so it > > will be handy included by other > > files. > > Use this commit message for your next submission: > > crash: Carve out crashkernel= cmdline parsing > > Make the "crashkernel=" parsing functionality available to the early > KASLR code. Will be used by a later patch to parse crashkernel regions > which KASLR should aviod. > OK.
> > Signed-off-by: Pingfan Liu <kernelf...@gmail.com> > > Cc: Thomas Gleixner <t...@linutronix.de> > > Cc: Ingo Molnar <mi...@redhat.com> > > Cc: Borislav Petkov <b...@alien8.de> > > Cc: "H. Peter Anvin" <h...@zytor.com> > > Cc: Baoquan He <b...@redhat.com> > > Cc: Will Deacon <will.dea...@arm.com> > > Cc: Nicolas Pitre <n...@linaro.org> > > Cc: Chao Fan <fanc.f...@cn.fujitsu.com> > > Cc: "Kirill A. Shutemov" <kirill.shute...@linux.intel.com> > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > > Cc: Vivek Goyal <vgo...@redhat.com> > > CC: Hari Bathini <hbath...@linux.vnet.ibm.com> > > Cc: linux-kernel@vger.kernel.org > > --- > > kernel/crash_core.c | 273 --------------------------------------------- > > lib/Makefile | 2 + > > lib/parse_crashkernel.c | 289 > > ++++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 291 insertions(+), 273 deletions(-) > > And this is not how you carve out code. > > First, you do a patch which does only code move. Nothing more. > > In a follow on patch, you make the changes to the moved code so that it > is immediately visible what you're changing. > Will fix it. Thanks for your review. Regards, Pingfan
