On 29-04-19, 22:52, tip-bot for Tobin C. Harding wrote: > Commit-ID: 8bf7ab9c79f3d1a5f02ebac369f656de9ec0aca8 > Gitweb: > https://git.kernel.org/tip/8bf7ab9c79f3d1a5f02ebac369f656de9ec0aca8 > Author: Tobin C. Harding <to...@kernel.org> > AuthorDate: Tue, 30 Apr 2019 10:11:44 +1000 > Committer: Ingo Molnar <mi...@kernel.org> > CommitDate: Tue, 30 Apr 2019 06:24:09 +0200 > > sched/cpufreq: Fix kobject memleak > > Currently the error return path from kobject_init_and_add() is not > followed by a call to kobject_put() - which means we are leaking > the kobject. > > Fix it by adding a call to kobject_put() in the error path of > kobject_init_and_add(). > > Signed-off-by: Tobin C. Harding <to...@kernel.org> > Add call to kobject_put() in error path of kobject_init_and_add().
This should have been present before the signed-off ? > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Linus Torvalds <torva...@linux-foundation.org> > Cc: Peter Zijlstra <pet...@infradead.org> > Cc: Rafael J. Wysocki <rafael.j.wyso...@intel.com> > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Tobin C. Harding <to...@kernel.org> > Cc: Vincent Guittot <vincent.guit...@linaro.org> > Cc: Viresh Kumar <viresh.ku...@linaro.org> > Link: http://lkml.kernel.org/r/20190430001144.24890-1-to...@kernel.org > Signed-off-by: Ingo Molnar <mi...@kernel.org> > --- > kernel/sched/cpufreq_schedutil.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/sched/cpufreq_schedutil.c > b/kernel/sched/cpufreq_schedutil.c > index 5c41ea367422..3638d2377e3c 100644 > --- a/kernel/sched/cpufreq_schedutil.c > +++ b/kernel/sched/cpufreq_schedutil.c > @@ -771,6 +771,7 @@ out: > return 0; > > fail: > + kobject_put(&tunables->attr_set.kobj); > policy->governor_data = NULL; > sugov_tunables_free(tunables); > -- viresh
