Hi Lukasz,

On 19. 5. 7. 오전 12:11, Lukasz Luba wrote:
> Define new IDs for clocks used by Dynamic Memory Controller in
> Exynos5422 SoC.
> 
> Acked-by: Rob Herring <r...@kernel.org>
> Signed-off-by: Lukasz Luba <l.l...@partner.samsung.com>
> ---
>  include/dt-bindings/clock/exynos5420.h | 28 ++++++++++++++++++++++------
>  1 file changed, 22 insertions(+), 6 deletions(-)
> 
> diff --git a/include/dt-bindings/clock/exynos5420.h 
> b/include/dt-bindings/clock/exynos5420.h
> index 355f469..bf50d8a 100644
> --- a/include/dt-bindings/clock/exynos5420.h
> +++ b/include/dt-bindings/clock/exynos5420.h
> @@ -60,6 +60,7 @@
>  #define CLK_MAU_EPLL         159
>  #define CLK_SCLK_HSIC_12M    160
>  #define CLK_SCLK_MPHY_IXTAL24        161
> +#define CLK_SCLK_BPLL                162
>  
>  /* gate clocks */
>  #define CLK_UART0            257
> @@ -195,6 +196,16 @@
>  #define CLK_ACLK432_CAM              518
>  #define CLK_ACLK_FL1550_CAM  519
>  #define CLK_ACLK550_CAM              520
> +#define CLK_CLKM_PHY0                521
> +#define CLK_CLKM_PHY1                522
> +#define CLK_ACLK_PPMU_DREX0_0        523
> +#define CLK_ACLK_PPMU_DREX0_1        524
> +#define CLK_ACLK_PPMU_DREX1_0        525
> +#define CLK_ACLK_PPMU_DREX1_1        526
> +#define CLK_PCLK_PPMU_DREX0_0        527
> +#define CLK_PCLK_PPMU_DREX0_1        528
> +#define CLK_PCLK_PPMU_DREX1_0        529
> +#define CLK_PCLK_PPMU_DREX1_1        530
>  
>  /* mux clocks */
>  #define CLK_MOUT_HDMI                640
> @@ -217,6 +228,8 @@
>  #define CLK_MOUT_EPLL                657
>  #define CLK_MOUT_MAU_EPLL    658
>  #define CLK_MOUT_USER_MAU_EPLL       659
> +#define CLK_MOUT_SCLK_SPLL   660
> +#define CLK_MOUT_MX_MSPLL_CCORE_PHY  661
>  
>  /* divider clocks */
>  #define CLK_DOUT_PIXEL               768
> @@ -243,13 +256,16 @@
>  #define CLK_DOUT_ACLK300_GSCL        789
>  #define CLK_DOUT_ACLK400_DISP1       790
>  #define CLK_DOUT_PCLK_CDREX  791
> -#define CLK_DOUT_SCLK_CDREX  792
> -#define CLK_DOUT_ACLK_CDREX1 793
> -#define CLK_DOUT_CCLK_DREX0  794
> -#define CLK_DOUT_CLK2X_PHY0  795
> -#define CLK_DOUT_PCLK_CORE_MEM       796

The your previous patch didn't change the id number
of already exiting clocks. It cause the fault.
In order to keep the compatibility, you keep
the original id number without modification.

Please don't change the id number of the existing clocks
and then just add the new clocks.


> +#define CLK_DOUT_PCLK_DREX0  792
> +#define CLK_DOUT_PCLK_DREX1  793
> +#define CLK_DOUT_SCLK_CDREX  794
> +#define CLK_DOUT_ACLK_CDREX1 795
> +#define CLK_DOUT_CCLK_DREX0  796
> +#define CLK_DOUT_CLK2X_PHY0  797
> +#define CLK_DOUT_PCLK_CORE_MEM       798
> +#define CLK_FF_DOUT_SPLL2    799
>  
>  /* must be greater than maximal clock id */
> -#define CLK_NR_CLKS          797
> +#define CLK_NR_CLKS          800
>  
>  #endif /* _DT_BINDINGS_CLOCK_EXYNOS_5420_H */
> 

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Reply via email to