> -----Original Message----- > From: Daniel Baluta [mailto:[email protected]] > Sent: Wednesday, May 15, 2019 7:47 PM > To: Anson Huang <[email protected]> > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; Leonard Crestez > <[email protected]>; [email protected]; > [email protected]; [email protected]; > [email protected]; Abel Vesa <[email protected]>; [email protected]; > [email protected]; [email protected]; dl-linux- > imx <[email protected]> > Subject: Re: [PATCH V2 1/2] soc: imx: Add SCU SoC info driver support > > Hi Anson, > > Since you are going to send a new version for this please consider my > comment inline. > > <snip> > > > +static u32 imx8qxp_soc_revision(void) { > > + struct imx_sc_msg_misc_get_soc_id msg; > > + struct imx_sc_rpc_msg *hdr = &msg.hdr; > > + u32 rev = 0; > > No need to initialize this here. > > > + int ret; > > + > > + hdr->ver = IMX_SC_RPC_VERSION; > > + hdr->svc = IMX_SC_RPC_SVC_MISC; > > + hdr->func = IMX_SC_MISC_FUNC_GET_CONTROL; > > + hdr->size = 3; > > + > > + msg.data.send.control = IMX_SC_C_ID; > > + msg.data.send.resource = IMX_SC_R_SYSTEM; > > + > > + ret = imx_scu_call_rpc(soc_ipc_handle, &msg, true); > > + if (ret) { > > + dev_err(&imx_scu_soc_pdev->dev, > > + "get soc info failed, ret %d\n", ret); > > + /* return 0 means getting revision failed */ > > Just return 0 here. No need for rev.
OK, thanks. Anson. > > + return rev; > > + } > > +
