Hi Oliver, thanks for the review. On Mon, 2019-05-20 at 14:43 +0200, Oliver Neukum wrote: > On Mo, 2019-05-20 at 12:47 +0200, Nicolas Saenz Julienne wrote: > > + * For more information on the firmware interface check: > > + * https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface > > + */ > > +struct bcm2835_firmware_prop { > > + u32 id; > > + u32 val; > > + u32 disable_turbo; > > +} __packed; > > Hi, > > technically we are not in arch and those fields have a defined > endianness. >
Well I set it as packed since it's 'sent' through a memory mapped firmware interface. Hence the need for the structure format to be fixed. So I guessed we're safer with it, as I'm not 100% sure what the different compilers are going to do with it (although it's very likely it'll stay the same). BTW this will be built both for arm & arm64. Regards, Nicolas
signature.asc
Description: This is a digitally signed message part
