On 5/20/19 12:52 AM, Amelie Delaunay wrote:
> When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does
> not exist:
> drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_probe':
> drivers/pinctrl/pinctrl-stmfx.c:652:17: error: 'struct gpio_chip' has no
> member named 'of_node'
> pctl->gpio_chip.of_node = np;
>
> Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver")
> Reported-by: kbuild test robot <l...@intel.com>
> Signed-off-by: Amelie Delaunay <amelie.delau...@st.com>
This is good as far as it goes, but I am also seeing a build error in
pinctrl-stmfx.c when CONFIG_OF is not set/enabled (randconfig):
../drivers/pinctrl/pinctrl-stmfx.c:409:20: error:
‘pinconf_generic_dt_node_to_map_pin’ undeclared here (not in a function)
.dt_node_to_map = pinconf_generic_dt_node_to_map_pin,
^
> ---
> drivers/pinctrl/pinctrl-stmfx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
> index eba872c..bb64aa0 100644
> --- a/drivers/pinctrl/pinctrl-stmfx.c
> +++ b/drivers/pinctrl/pinctrl-stmfx.c
> @@ -648,7 +648,9 @@ static int stmfx_pinctrl_probe(struct platform_device
> *pdev)
> pctl->gpio_chip.base = -1;
> pctl->gpio_chip.ngpio = pctl->pctl_desc.npins;
> pctl->gpio_chip.can_sleep = true;
> +#ifdef CONFIG_OF_GPIO
> pctl->gpio_chip.of_node = np;
> +#endif
> pctl->gpio_chip.need_valid_mask = true;
>
> ret = devm_gpiochip_add_data(pctl->dev, &pctl->gpio_chip, pctl);
>
--
~Randy
