Hello,
Masahiro Yamada wrote:
> Commit 9cc342f6c4a0 ("treewide: prefix header search paths with
> $(srctree)/") caused a build error for MIPS VDSO.
>
> CC arch/mips/vdso/gettimeofday.o
> In file included from ../arch/mips/vdso/vdso.h:26,
> from ../arch/mips/vdso/gettimeofday.c:11:
> ../arch/mips/include/asm/page.h:12:10: fatal error: spaces.h: No such file or
> directory
> #include <spaces.h>
> ^~~~~~~~~~
>
> The cause of the error is a missing space after the compiler flag -I .
>
> Kbuild used to have a global restriction "no space after -I", but
> commit 48f6e3cf5bc6 ("kbuild: do not drop -I without parameter") got
> rid of it. Having a space after -I is no longer a big deal as far as
> Kbuild is concerned.
>
> It is still a big deal for MIPS because arch/mips/vdso/Makefile
> filters the header search paths, like this:
>
> ccflags-vdso := $(filter -I%,$(KBUILD_CFLAGS))
> ..., which relies on the assumption that there is no space after -I .
>
> Fixes: 9cc342f6c4a0 ("treewide: prefix header search paths with $(srctree)/")
> Reported-by: kbuild test robot <l...@intel.com>
> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
Applied to mips-fixes.
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.bur...@mips.com to report it. ]
