Pavel
Thanks for the review
On 5/23/19 7:50 AM, Pavel Machek wrote:
> Hi!
>
>> +++ b/drivers/leds/leds-lm36274.c
>
>> +static int lm36274_parse_dt(struct lm36274 *lm36274_data)
>> +{
>> + struct fwnode_handle *child = NULL;
>> + char label[LED_MAX_NAME_SIZE];
>> + struct device *dev = &lm36274_data->pdev->dev;
>> + const char *name;
>> + int child_cnt;
>> + int ret = -EINVAL;
>> +
>> + /* There should only be 1 node */
>> + child_cnt = device_get_child_node_count(dev);
>> + if (child_cnt != 1)
>> + return ret;
>
> I'd do explicit "return -EINVAL" here.
>
ACK
>> +static int lm36274_probe(struct platform_device *pdev)
>> +{
>> + struct ti_lmu *lmu = dev_get_drvdata(pdev->dev.parent);
>> + struct lm36274 *lm36274_data;
>> + int ret;
>> +
>> + lm36274_data = devm_kzalloc(&pdev->dev, sizeof(*lm36274_data),
>> + GFP_KERNEL);
>> + if (!lm36274_data) {
>> + ret = -ENOMEM;
>> + return ret;
>> + }
>
> And certainly do "return -ENOMEM" explicitly here.
>
ACK
> Acked-by: Pavel Machek <pa...@ucw.cz>
> Pavel
>
