On Tue, 28 May 2019, Christoph Hellwig wrote: > > wd719x_chip_init is getting called in interrupt disabled > > mode(spin_lock_irqsave) , so we need to GFP_ATOMIC instead > > of GFP_KERNEL. > > > > Issue identified by coccicheck > > I don't think request_firmware is any more happy being called under > a spinlock. The right fix is to not hold a spinlock over the board > initialization. >
Right, and not even wd719x_chip_init() is always called in this context otherwise wd719x_board_found() would also need the same change.
