From: Biao Huang <biao.hu...@mediatek.com> Date: Thu, 30 May 2019 17:43:15 +0800
> @@ -364,6 +371,15 @@ static int mediatek_dwmac_probe(struct platform_device > *pdev) > return 0; > } > > +static int mediatek_dwmac_remove(struct platform_device *pdev) > +{ > + int ret; > + > + ret = stmmac_pltfr_remove(pdev); > + > + return ret; > +} > + > static const struct of_device_id mediatek_dwmac_match[] = { > { .compatible = "mediatek,mt2712-gmac", > .data = &mt2712_gmac_variant }, > @@ -374,7 +390,7 @@ static int mediatek_dwmac_probe(struct platform_device > *pdev) > > static struct platform_driver mediatek_dwmac_driver = { > .probe = mediatek_dwmac_probe, > - .remove = stmmac_pltfr_remove, > + .remove = mediatek_dwmac_remove, > .driver = { > .name = "dwmac-mediatek", > .pm = &stmmac_pltfr_pm_ops, This half of your patch has no effect and seems completely unnecessary. Please remove it.