-----Original Message----- From: Linus Walleij <[email protected]> Sent: Monday, June 3, 2019 7:08 PM To: Hongwei Zhang <[email protected]> Cc: Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; open list:GPIO SUBSYSTEM <[email protected]>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <[email protected]>; Linux ARM <[email protected]>; [email protected]; [email protected] Subject: Re: [PATCH linux dev-5.1 v1] ARM: dts: aspeed: Add SGPM pinmux
Hi Hongwei, On Tue, Jun 4, 2019 at 12:44 AM Hongwei Zhang <[email protected]> wrote: > > Add SGPM pinmux to ast2500-pinctrl function and group, to prepare for > supporting SGPIO in AST2500 SoC. > > Signed-off-by: Hongwei Zhang <[email protected]> > --- > Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt | 2 +- > arch/arm/boot/dts/aspeed-g5.dtsi | 5 +++++ > drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 4 ++++ Please try to separate out the change to arch/arm/boot/dts/aspeed-g5.dtsi into a separate patch that goes through ARM SoC. Just committed the DT patch to _https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git , please help to review. Thanks! Other than that it looks fine to me. Yours, Linus Walleij
