On Sat, Jun 08, 2019 at 08:06:14PM +0200, Martin Blumenstingl wrote:
> Simplify the code which fetches the input clock for a PWM channel by
> using devm_clk_get_optional().
> This comes with a small functional change: previously all errors except
> EPROBE_DEFER were ignored. Now all other errors are also treated as
> errors. If no input clock is present devm_clk_get_optional() will return
> NULL instead of an error which matches the behavior of the old code.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
> Reviewed-by: Neil Armstrong <narmstr...@baylibre.com>

Nitpick: Put your S-o-b last. Otherwise this ends as

        Sgned-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
        Rviewed-by: Neil Armstrong <narmstr...@baylibre.com>
        Sgned-off-by: Thierry Reding <thierry.red...@gmail.com>

and this implies that Thierry added Neil's tag.  (Typos are done on
purpose to not confuse patchwork.)

Reviewed-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Reply via email to