-----Original Message----- From: Greg Kroah-Hartman <gre...@linuxfoundation.org> Sent: Tuesday, June 11, 2019 12:20 AM To: Pavel Shilovskiy <pshi...@microsoft.com> Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Christoph Probst <ker...@probst.it>; Steven French <steven.fre...@microsoft.com> Subject: Re: [PATCH 4.4 041/241] cifs: fix strcat buffer overflow and reduce raciness in smb21_set_oplock_level()
On Mon, Jun 10, 2019 at 07:13:24PM +0000, Pavel Shilovskiy wrote: > > -----Original Message----- > From: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Sent: Sunday, June 9, 2019 9:40 AM > To: linux-kernel@vger.kernel.org > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>; > sta...@vger.kernel.org; Christoph Probst <ker...@probst.it>; Pavel > Shilovskiy <pshi...@microsoft.com>; Steven French > <steven.fre...@microsoft.com> > Subject: [PATCH 4.4 041/241] cifs: fix strcat buffer overflow and > reduce raciness in smb21_set_oplock_level() > > From: Christoph Probst <ker...@probst.it> > > commit 6a54b2e002c9d00b398d35724c79f9fe0d9b38fb upstream. > > Change strcat to strncpy in the "None" case to fix a buffer overflow when > cinode->oplock is reset to 0 by another thread accessing the same cinode. It > is never valid to append "None" to any other message. > > Consolidate multiple writes to cinode->oplock to reduce raciness. > > Signed-off-by: Christoph Probst <ker...@probst.it> > Reviewed-by: Pavel Shilovsky <pshi...@microsoft.com> > Signed-off-by: Steve French <stfre...@microsoft.com> > CC: Stable <sta...@vger.kernel.org> > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> > -------------------------------- > > Hi Greg, > > This patch has been queued for 4.4.y and has already been merged into > 5.1.y (5.1.5). Are you going to apply it to other stable kernels: 4.9, > 4.14, 4.19? It is already in the 4.9.179, 4.14.122, 4.19.46, 5.0.19, and 5.1.5 released kernels. So I don't think I can merge it into them again :) thanks, greg k-h --------------------------------- You are right, I missed it somehow. Thanks for clarifying! Best regards, Pavel Shilovsky
