On Sat, Jun 15, 2019 at 01:30:39AM +0000, Z.q. Hou wrote:
> Hi Lorenzo,
>
> > -----Original Message-----
> > From: Lorenzo Pieralisi [mailto:[email protected]]
> > Sent: 2019年6月12日 21:08
> > To: Z.q. Hou <[email protected]>
> > Cc: [email protected]; [email protected];
> > [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; Leo Li
> > <[email protected]>; [email protected]; [email protected];
> > Mingkai Hu <[email protected]>; M.h. Lian <[email protected]>;
> > Xiaowei Bao <[email protected]>
> > Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag
> > MSI_FLAG_MULTI_PCI_MSI
> >
> > On Wed, Jun 12, 2019 at 11:34:51AM +0000, Z.q. Hou wrote:
> > > Hi Lorenzo,
> > >
> > > Thanks a lot for your comments!
> > >
> > > > -----Original Message-----
> > > > From: Lorenzo Pieralisi <[email protected]>
> > > > Sent: 2019年6月12日 1:00
> > > > To: Z.q. Hou <[email protected]>
> > > > Cc: [email protected]; [email protected];
> > > > [email protected]; [email protected];
> > > > [email protected]; [email protected]; [email protected];
> > > > [email protected]; [email protected]; Leo Li
> > > > <[email protected]>; [email protected];
> > [email protected];
> > > > Mingkai Hu <[email protected]>; M.h. Lian
> > <[email protected]>;
> > > > Xiaowei Bao <[email protected]>
> > > > Subject: Re: [PATCHv5 04/20] PCI: mobiveil: Remove the flag
> > > > MSI_FLAG_MULTI_PCI_MSI
> > > >
> > > > On Fri, Apr 12, 2019 at 08:35:36AM +0000, Z.q. Hou wrote:
> > > > > From: Hou Zhiqiang <[email protected]>
> > > > >
> > > > > The current code does not support multiple MSIs, so remove the
> > > > > corresponding flag from the msi_domain_info structure.
> > > >
> > > > Please explain me what's the problem before removing multi MSI support.
> > >
> > > NXP LX2 PCIe use the GIC-ITS instead of Mobiveil IP internal MSI
> > > controller, so, I didn't encounter problem.
> >
> > Well, you sent a patch to fix an issue, explain me the issue you are fixing
> > then,
> > aka what have you sent this patch for ?
>
> I did not face issue, as I have explained NXP does not use the
> Mobiveil IP's MSI controller. But obviously the MSI allocate function
> does not support multiple MSI, so I submitted this patch.
There is nothing obvious. Write what you are fixing in the commit log
and I will apply the patch, I won't write the commit log for you. Anyone
should be able to understand why a patch was needed by reading the
commit log, it is as important as writing the code itself.
Thanks,
Lorenzo
> Thanks,
> Zhiqiang
>
> >
> > Lorenzo
> >
> > > Subbu, did you test with Endpoint supporting multi MSI?
> > >
> > > Thanks,
> > > Zhiqiang
> > >
> > > >
> > > > Thanks,
> > > > Lorenzo
> > > >
> > > > > Fixes: 1e913e58335f ("PCI: mobiveil: Add MSI support")
> > > > > Signed-off-by: Hou Zhiqiang <[email protected]>
> > > > > Reviewed-by: Minghuan Lian <[email protected]>
> > > > > ---
> > > > > V5:
> > > > > - Corrected the subject.
> > > > >
> > > > > drivers/pci/controller/pcie-mobiveil.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/pci/controller/pcie-mobiveil.c
> > > > > b/drivers/pci/controller/pcie-mobiveil.c
> > > > > index 563210e731d3..a0dd337c6214 100644
> > > > > --- a/drivers/pci/controller/pcie-mobiveil.c
> > > > > +++ b/drivers/pci/controller/pcie-mobiveil.c
> > > > > @@ -703,7 +703,7 @@ static struct irq_chip mobiveil_msi_irq_chip =
> > > > > {
> > > > >
> > > > > static struct msi_domain_info mobiveil_msi_domain_info = {
> > > > > .flags = (MSI_FLAG_USE_DEF_DOM_OPS |
> > > > MSI_FLAG_USE_DEF_CHIP_OPS |
> > > > > - MSI_FLAG_MULTI_PCI_MSI | MSI_FLAG_PCI_MSIX),
> > > > > + MSI_FLAG_PCI_MSIX),
> > > > > .chip = &mobiveil_msi_irq_chip,
> > > > > };
> > > > >
> > > > > --
> > > > > 2.17.1
> > > > >
