On Tue, Jun 11, 2019 at 09:31:25AM +0800, anson.hu...@nxp.com wrote: > From: Anson Huang <anson.hu...@nxp.com> > > This patch adds i.MX8MN SoC driver support: > > root@imx8mnevk:~# cat /sys/devices/soc0/family > Freescale i.MX > > root@imx8mnevk:~# cat /sys/devices/soc0/machine > NXP i.MX8MNano DDR4 EVK board > > root@imx8mnevk:~# cat /sys/devices/soc0/soc_id > i.MX8MN > > root@imx8mnevk:~# cat /sys/devices/soc0/revision > 1.0 > > Signed-off-by: Anson Huang <anson.hu...@nxp.com> > --- > drivers/soc/imx/soc-imx8.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c > index 3842d09..02309a2 100644 > --- a/drivers/soc/imx/soc-imx8.c > +++ b/drivers/soc/imx/soc-imx8.c > @@ -55,7 +55,12 @@ static u32 __init imx8mm_soc_revision(void) > void __iomem *anatop_base; > u32 rev; > > - np = of_find_compatible_node(NULL, NULL, "fsl,imx8mm-anatop"); > + if (of_machine_is_compatible("fsl,imx8mm")) > + np = of_find_compatible_node(NULL, NULL, "fsl,imx8mm-anatop"); > + else if (of_machine_is_compatible("fsl,imx8mn")) > + np = of_find_compatible_node(NULL, NULL, "fsl,imx8mn-anatop");
Can we have this anatop compatible in imx8_soc_data, so that we may save the call to of_machine_is_compatible()? Shawn > + else > + np = NULL; > if (!np) > return 0; > > @@ -79,9 +84,15 @@ static const struct imx8_soc_data imx8mm_soc_data = { > .soc_revision = imx8mm_soc_revision, > }; > > +static const struct imx8_soc_data imx8mn_soc_data = { > + .name = "i.MX8MN", > + .soc_revision = imx8mm_soc_revision, > +}; > + > static const struct of_device_id imx8_soc_match[] = { > { .compatible = "fsl,imx8mq", .data = &imx8mq_soc_data, }, > { .compatible = "fsl,imx8mm", .data = &imx8mm_soc_data, }, > + { .compatible = "fsl,imx8mn", .data = &imx8mn_soc_data, }, > { } > }; > > -- > 2.7.4 >