As this change doesn't affect other users I thought it is safe to do it from PCI wrapper driver. But yes I agree that right way is to do it in PHY driver. I would like to drop this patch, please ignore only this patch from series.
>-----Original Message----- >From: Andrew Lunn <and...@lunn.ch> >Sent: Monday, June 17, 2019 8:35 PM >To: Parshuram Raju Thombare <pthom...@cadence.com> >Cc: nicolas.fe...@microchip.com; da...@davemloft.net; f.faine...@gmail.com; >net...@vger.kernel.org; hkallwe...@gmail.com; linux-kernel@vger.kernel.org; >Rafal Ciepiela <raf...@cadence.com>; Anil Joy Varughese ><anil...@cadence.com>; Piotr Sroka <pio...@cadence.com> >Subject: Re: [PATCH 0/6] net: macb patch set cover letter > >EXTERNAL MAIL > > >> 3. 003-net-macb-add-PHY-configuration-in-MACB-PCI-wrapper.patch >> This patch is to configure TI PHY DP83867 in SGMII mode from >> our MAC PCI wrapper driver. >> With this change there is no need of PHY driver and dp83867 >> module must be disabled. Users wanting to setup DP83867 PHY >> in SGMII mode can disable dp83867.ko driver, else dp83867.ko >> overwrite this configuration and PHY is setup as per dp83867.ko. > >This sounds very wrong. Why not make the dp83867 driver support SGMII? > > Andrew Regards, Parshuram Thombare
