On Tue, Jun 18, 2019 at 9:09 AM 'Nathan Huckleberry' via Clang Built Linux <[email protected]> wrote: > > There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops' > Added a usage consistent with other fops to dump pmap > to userspace. > > Cc: [email protected] > Link: https://github.com/ClangBuiltLinux/linux/issues/529 > Signed-off-by: Nathan Huckleberry <[email protected]>
Looks good to me based on Maxime's suggestion. Thanks for seeking clarification and following up on the feedback. Reviewed-by: Nick Desaulniers <[email protected]> Nathan, you should use Suggested-by tags (liberally, IMO) when your patch is based on feedback from others, in this case: Suggested-by: Maxime Chevallier <[email protected]> > --- > drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c > index 0ee39ea47b6b..55947bc63cfd 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c > @@ -566,6 +566,9 @@ static int mvpp2_dbgfs_prs_entry_init(struct dentry > *parent, > debugfs_create_file("hits", 0444, prs_entry_dir, entry, > &mvpp2_dbgfs_prs_hits_fops); > > + ddebugfs_create_file("pmap", 0444, prs_entry_dir, entry, > + &mvpp2_dbgfs_prs_pmap_fops); > + -- Thanks, ~Nick Desaulniers
