On Tue, 18 Jun 2019 12:23:22 -0400 Steven Rostedt <rost...@goodmis.org> wrote:
> > Oops, good catch! > > This part is related to caller (ftrace/perf) so should be more careful. > > Usually, kprobe enablement should not fail. If one of them has > > gone (like a probe on unloaded module), it can be fail but that > > should be ignored. I would like to add some additional check so that > > - If all kprobes are on the module which is unloaded, enablement > > must be failed and return error. > > - If any kprobe is enabled, and others are on non-exist modules, > > it should succeeded and return OK. > > - If any kprobe caused an error not because of unloaded module, > > all other enablement should be canceled and return error. > > > > Is that OK for you? > > > > Sounds good to me. BTW, I pulled in patches 1-9 and I'm starting to test them now. -- Steve
