On Fri, Jun 14, 2019 at 04:54:32PM +0800, Yinbo Zhu wrote: > From: Ramneek Mehresh <[email protected]> > > USB erratum-A006918 workaround tries to start internal PHY inside > uboot (when PLL fails to lock). However, if the workaround also > fails, then USB initialization is also stopped inside Linux. > Erratum-A006918 workaround failure creates "fsl,erratum_a006918" > node in device-tree. Presence of this node in device-tree is > used to stop USB controller initialization in Linux > > Signed-off-by: Ramneek Mehresh <[email protected]> > Signed-off-by: Suresh Gupta <[email protected]> > Signed-off-by: Yinbo Zhu <[email protected]> > --- > Change in v7: > keep v5 version "fall through" > > drivers/usb/host/ehci-fsl.c | 9 +++++++++ > drivers/usb/host/fsl-mph-dr-of.c | 3 ++- > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c > index 8f3bf3efb038..ef3dfd33a62e 100644 > --- a/drivers/usb/host/ehci-fsl.c > +++ b/drivers/usb/host/ehci-fsl.c > @@ -236,6 +236,15 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd, > portsc |= PORT_PTS_PTW; > /* fall through */ > case FSL_USB2_PHY_UTMI: > + /* Presence of this node "has_fsl_erratum_a006918" > + * in device-tree is used to stop USB controller > + * initialization in Linux > + */ > + if (pdata->has_fsl_erratum_a006918) { > + dev_warn(dev, "USB PHY clock invalid\n"); > + return -EINVAL; > + } > +
You need a /* fall through */ comment here, right? thanks, greg k-h
