On Fri, Jun 21, 2019 at 1:21 PM Nathan Chancellor <[email protected]> wrote: > > Clang warns when CONFIG_ACPI is unset: > > drivers/pinctrl/qcom/pinctrl-sdm845.c:1320:5: warning: 'CONFIG_ACPI' is > not defined, evaluates to 0 [-Wundef] > #if CONFIG_ACPI > ^ > 1 warning generated. > > Use ifdef instead of if to resolve this. > > Fixes: a229105d7a1e ("pinctrl: qcom: sdm845: Provide ACPI support") > Link: https://github.com/ClangBuiltLinux/linux/issues/569 > Signed-off-by: Nathan Chancellor <[email protected]>
Thanks for the patch. Reviewed-by: Nick Desaulniers <[email protected]> > --- > drivers/pinctrl/qcom/pinctrl-sdm845.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sdm845.c > b/drivers/pinctrl/qcom/pinctrl-sdm845.c > index 06790e5ece6c..39f498c09906 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sdm845.c > +++ b/drivers/pinctrl/qcom/pinctrl-sdm845.c > @@ -1317,7 +1317,7 @@ static int sdm845_pinctrl_probe(struct platform_device > *pdev) > return ret; > } > > -#if CONFIG_ACPI > +#ifdef CONFIG_ACPI Thanks, ~Nick Desaulniers
