On Wed, 26 Jun 2019, Ingo Molnar wrote:
> * Thomas Gleixner <[email protected]> wrote:
> > - evt->set_state_shutdown = hpet_msi_shutdown;
> > - evt->set_state_oneshot = hpet_msi_set_oneshot;
> > - evt->tick_resume = hpet_msi_resume;
> > - evt->set_next_event = hpet_msi_next_event;
> > + evt->set_state_shutdown = hpet_clkevt_shutdown;
> > + evt->set_state_oneshot = hpet_clkevt_set_oneshot;
> > + evt->set_next_event = hpet_clkevt_set_next_event;
> > + evt->tick_resume = hpet_clkevt_msi_resume;
> > evt->cpumask = cpumask_of(hc->cpu);
>
> My compulsive-obsessive half really wants this to look like:
>
> > + evt->set_state_shutdown = hpet_clkevt_shutdown;
> > + evt->set_state_oneshot = hpet_clkevt_set_oneshot;
> > + evt->set_next_event = hpet_clkevt_set_next_event;
> > + evt->tick_resume = hpet_clkevt_msi_resume;
> > evt->cpumask = cpumask_of(hc->cpu);
Just to remove all of that in the next patch again, which then has the
proper aligned thing to make you happy :)
> Also, maybe harmonize the callback names with the local function names,
> like hpet_clkevt_set_next_event() already does and
> hpet_clkevt_set_oneshot() almost does:
>
> s/hpet_clkevt_shutdown
> /hpet_clkevt_set_state_shutdown
>
> s/hpet_clkevt_set_oneshot
> /hpet_clkevt_set_state_oneshot
>
> s/hpet_clkevt_msi_resume
> /hpet_clkevt_tick_resume
>
> ... unless the name variations have some hidden purpose and meaning?
Historical but we want to preserve some of the old stuff for sentimental
reasons.
Thanks,
tglx
