On Sat, 13 Jul 2019 at 05:48, Wen Yang <[email protected]> wrote: > > The cpu_dai variable is still being used after the of_node_put() call, > which may result in double-free: > > of_node_put(cpu_dai); ---> released here > > ret = devm_snd_soc_register_card(dev, card); > if (ret < 0) { > ... > goto err_put_clk_i2s; --> jump to err_put_clk_i2s > ... > > err_put_clk_i2s: > clk_put(priv->clk_i2s_bus); > err_put_sclk: > clk_put(priv->sclk_i2s); > err_put_cpu_dai: > of_node_put(cpu_dai); --> double-free here > > Fixes: d832d2b246c5 ("ASoC: samsung: odroid: Fix of_node refcount unbalance") > Signed-off-by: Wen Yang <[email protected]> > Cc: Krzysztof Kozlowski <[email protected]> > Cc: Sangbeom Kim <[email protected]> > Cc: Sylwester Nawrocki <[email protected]> > Cc: Liam Girdwood <[email protected]> > Cc: Mark Brown <[email protected]> > Cc: Jaroslav Kysela <[email protected]> > Cc: Takashi Iwai <[email protected]> > Cc: [email protected] > Cc: [email protected] > --- > sound/soc/samsung/odroid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Reviewed-by: Krzysztof Kozlowski <[email protected]> Best regards, Krzysztof
