It should call spin_unlock() before return NULL.
Detected by Coccinelle.

Reported-by: Hulk Robot <hul...@huawei.com>
Fixes: f3097be21bf1 net: ("dsa: sja1105: Add a state machine for RX 
timestamping")
Signed-off-by: YueHaibing <yuehaib...@huawei.com>
---
 net/dsa/tag_sja1105.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/dsa/tag_sja1105.c b/net/dsa/tag_sja1105.c
index 1d96c9d..26363d7 100644
--- a/net/dsa/tag_sja1105.c
+++ b/net/dsa/tag_sja1105.c
@@ -216,6 +216,7 @@ static struct sk_buff
                if (!skb) {
                        dev_err_ratelimited(dp->ds->dev,
                                            "Failed to copy stampable skb\n");
+                       spin_unlock(&sp->data->meta_lock);
                        return NULL;
                }
                sja1105_transfer_meta(skb, meta);
-- 
2.7.4


Reply via email to