Hi Qian, Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v5.2 next-20190719] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Qian-Cai/be2net-fix-adapter-big_page_size-miscaculation/20190713-191644 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/net/ethernet/emulex/benet/be_main.c: In function 'be_rx_cqs_create': >> drivers/net/ethernet/emulex/benet/be_main.c:3138:33: error: implicit >> declaration of function '__get_order'; did you mean 'get_order'? >> [-Werror=implicit-function-declaration] adapter->big_page_size = (1 << __get_order(rx_frag_size)) * PAGE_SIZE; ^~~~~~~~~~~ get_order cc1: some warnings being treated as errors vim +3138 drivers/net/ethernet/emulex/benet/be_main.c 3116 3117 static int be_rx_cqs_create(struct be_adapter *adapter) 3118 { 3119 struct be_queue_info *eq, *cq; 3120 struct be_rx_obj *rxo; 3121 int rc, i; 3122 3123 adapter->num_rss_qs = 3124 min(adapter->num_evt_qs, adapter->cfg_num_rx_irqs); 3125 3126 /* We'll use RSS only if atleast 2 RSS rings are supported. */ 3127 if (adapter->num_rss_qs < 2) 3128 adapter->num_rss_qs = 0; 3129 3130 adapter->num_rx_qs = adapter->num_rss_qs + adapter->need_def_rxq; 3131 3132 /* When the interface is not capable of RSS rings (and there is no 3133 * need to create a default RXQ) we'll still need one RXQ 3134 */ 3135 if (adapter->num_rx_qs == 0) 3136 adapter->num_rx_qs = 1; 3137 > 3138 adapter->big_page_size = (1 << __get_order(rx_frag_size)) * > PAGE_SIZE; 3139 for_all_rx_queues(adapter, rxo, i) { 3140 rxo->adapter = adapter; 3141 cq = &rxo->cq; 3142 rc = be_queue_alloc(adapter, cq, RX_CQ_LEN, 3143 sizeof(struct be_eth_rx_compl)); 3144 if (rc) 3145 return rc; 3146 3147 u64_stats_init(&rxo->stats.sync); 3148 eq = &adapter->eq_obj[i % adapter->num_evt_qs].q; 3149 rc = be_cmd_cq_create(adapter, cq, eq, false, 3); 3150 if (rc) 3151 return rc; 3152 } 3153 3154 dev_info(&adapter->pdev->dev, 3155 "created %d RX queue(s)\n", adapter->num_rx_qs); 3156 return 0; 3157 } 3158 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
