> On Jul 22, 2019, at 12:47 PM, Rasmus Villemoes <li...@rasmusvillemoes.dk> > wrote: > > On 19/07/2019 02.58, Nadav Amit wrote: > >> /* >> @@ -865,7 +893,7 @@ void arch_tlbbatch_flush(struct >> arch_tlbflush_unmap_batch *batch) >> if (cpumask_test_cpu(cpu, &batch->cpumask)) { >> lockdep_assert_irqs_enabled(); >> local_irq_disable(); >> - flush_tlb_func_local(&full_flush_tlb_info); >> + flush_tlb_func_local((void *)&full_flush_tlb_info); >> local_irq_enable(); >> } > > I think the confusion could be cleared up if you moved this hunk to > patch 2 where it belongs - i.e. where you change the prototype of > flush_tlb_func_local() and hence introduce the warning.
Yes, there is a small mess here - the constification should actually go to a different patch… I’ll fix it.