> -----Original Message----- > From: David Binderman [mailto:dcb...@hotmail.com] > Sent: Monday, July 22, 2019 4:12 PM > To: Pkshih; kv...@codeaurora.org; da...@davemloft.net; > linux-wirel...@vger.kernel.org; > net...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8*/sw.c: many > redundant assignments ? > > Hello there, > > > [linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c:120]: > > (warning) Redundant > assignment of 'rtlpriv->cfg->mod_params->disable_watchdog' to itself. > > [linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c:134]: > > (warning) Redundant > assignment of 'rtlpriv->cfg->mod_params->disable_watchdog' to itself. > > [linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c:133]: > > (warning) Redundant > assignment of 'rtlpriv->cfg->mod_params->disable_watchdog' to itself. > > [linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c:150]: > > (warning) Redundant > assignment of 'rtlpriv->cfg->mod_params->disable_watchdog' to itself. > > [linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c:118]: > > (warning) Redundant > assignment of 'rtlpriv->cfg->mod_params->sw_crypto' to itself. > > [linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c:116]: > > (warning) Redundant > assignment of 'rtlpriv->cfg->mod_params->sw_crypto' to itself. > > [linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c:42]: > > (warning) Redundant > assignment of 'rtlpriv->cfg->mod_params->sw_crypto' to itself. > > [linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8192se/sw.c:164]: > > (warning) Redundant > assignment of 'rtlpriv->cfg->mod_params->sw_crypto' to itself. > > [linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c:132]: > > (warning) Redundant > assignment of 'rtlpriv->cfg->mod_params->sw_crypto' to itself. > > [linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c:131]: > > (warning) Redundant > assignment of 'rtlpriv->cfg->mod_params->sw_crypto' to itself. > > [linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c:148]: > > (warning) Redundant > assignment of 'rtlpriv->cfg->mod_params->sw_crypto' to itself. > > Might be worth a look >
I send a patch to fix it. https://patchwork.kernel.org/patch/11053745/ Thank you. --- PK
