On Wed, Jul 24, 2019 at 1:28 AM Toru Komatsu <[email protected]> wrote: > > On 07/24, Masahiro Yamada wrote: > > Just a nit. > > > > The patch title is: > > .gitignore: Add compilation database "files" > > > > Maybe, should it be singular? > > > > > > On Sun, Jul 21, 2019 at 5:55 PM Toru Komatsu <[email protected]> wrote: > > > > > > This file is used by clangd to use language server protocol. > > > It can be generated at each compile using scripts/gen_compile_commands.py. > > > Therefore it is different depending on the environment and should be > > > ignored. > > > > > > Signed-off-by: Toru Komatsu <[email protected]> > > > --- > > > .gitignore | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/.gitignore b/.gitignore > > > index 8f5422cba6e2..025d887f64f1 100644 > > > --- a/.gitignore > > > +++ b/.gitignore > > > @@ -142,3 +142,6 @@ x509.genkey > > > > > > # Kdevelop4 > > > *.kdev4 > > > + > > > +# Clang's compilation database files > > > +/compile_commands.json > > > -- > > > 2.17.1 > > > > > > > > > -- > > Best Regards > > Masahiro Yamada > > -- > > Thanks for your review. > > Sorry, this point which you pointed out is my mistake. > It is should be "file". > > I'm begginer because this patch is my first time, > What should I do next?
This patch is trivial enough. I will change "files" -> "file" (patch subject and code), then I will apply it. Thanks. -- Best Regards Masahiro Yamada
