On Thu, Jul 25, 2019 at 08:10:49AM +0200, Sedat Dilek wrote: > On Thu, Jul 25, 2019 at 12:48 AM Josh Poimboeuf <[email protected]> wrote: > > > > Objtool reports: > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > .altinstr_replacement+0x36: redundant UACCESS disable > > > > __copy_from_user() already does both STAC and CLAC, so the > > user_access_end() in its error path adds an extra unnecessary CLAC. > > > > Fixes: 0b2c8f8b6b0c ("i915: fix missing user_access_end() in page fault > > exception case") > > Reported-by: Thomas Gleixner <[email protected]> > > Reported-by: Sedat Dilek <[email protected]> > > Acked-by: Peter Zijlstra (Intel) <[email protected]> > > Tested-by: Nick Desaulniers <[email protected]> > > Link: https://github.com/ClangBuiltLinux/linux/issues/617 > > Signed-off-by: Josh Poimboeuf <[email protected]> > > Just for the records and ensuing ages: > > Tested-by: Sedat Dilek <[email protected]>
Thanks Sedat. Since the objtool fix already got merged separately I'll resend this patch to the drm folks. -- Josh
