On Fri, Jul 26, 2019 at 02:42:43AM +0800, Pengfei Li wrote: > Objective > ---- > The motivation for this series of patches is use unsigned int for > "order" in compaction.c, just like in other memory subsystems. >
Why? The series is relatively subtle in parts, particularly patch 5. There have been places where by it was important for order to be able to go negative due to loop exit conditions. If there was a gain from this or it was a cleanup in the context of another major body of work, I could understand the justification but that does not appear to be the case here. -- Mel Gorman SUSE Labs