Hi Marc, On 2019/7/26 17:18, Marc Zyngier wrote: > On Fri, 26 Jul 2019 09:51:45 +0800 > Shaokun Zhang <zhangshao...@hisilicon.com> wrote: > >> From: Nianyao Tang <tangnian...@huawei.com> >> >> In its_vpe_init, when its_alloc_vpe_table fails, we should free >> vpt_page allocated just before, instead of vpe->vpt_page. >> Let's fix it. >> >> Cc: Thomas Gleixner <t...@linutronix.de> >> Cc: Jason Cooper <ja...@lakedaemon.net> >> Cc: Marc Zyngier <marc.zyng...@arm.com> >> Signed-off-by: Nianyao Tang <tangnian...@huawei.com> >> --- >> drivers/irqchip/irq-gic-v3-its.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/irqchip/irq-gic-v3-its.c >> b/drivers/irqchip/irq-gic-v3-its.c >> index 730fbe0..1b5c367 100644 >> --- a/drivers/irqchip/irq-gic-v3-its.c >> +++ b/drivers/irqchip/irq-gic-v3-its.c >> @@ -3010,7 +3010,7 @@ static int its_vpe_init(struct its_vpe *vpe) >> >> if (!its_alloc_vpe_table(vpe_id)) { >> its_vpe_id_free(vpe_id); >> - its_free_pending_table(vpe->vpt_page); >> + its_free_pending_table(vpt_page); >> return -ENOMEM; >> } >> > > Oops, well caught. Please repost this patch with your own SoB added > though, as you're posting the patch on behalf of someone else. >
Thanks your reminder and I will do it in v2 version. Shaokun > Thanks, > > M. >