Re: [alsa-devel] [RFC PATCH 16/40] soundwire: cadence_master: improve startup sequence with link hw_reset

[Pierre-Louis Bossart]

+static int do_reset(struct sdw_cdns *cdns)
+{
+       int ret;
+
+       /* program maximum length reset to be safe */
+       cdns_updatel(cdns, CDNS_MCP_CONTROL,
+                    CDNS_MCP_CONTROL_RST_DELAY,
+                    CDNS_MCP_CONTROL_RST_DELAY);
+
+       /* use hardware generated reset */
+       cdns_updatel(cdns, CDNS_MCP_CONTROL,
+                    CDNS_MCP_CONTROL_HW_RST,
+                    CDNS_MCP_CONTROL_HW_RST);
+
+       /* enable bus operations with clock and data */
+       cdns_updatel(cdns, CDNS_MCP_CONFIG,
+                    CDNS_MCP_CONFIG_OP,
+                    CDNS_MCP_CONFIG_OP_NORMAL);
+
+       /* commit changes */
+       ret = cdns_update_config(cdns);
+
+       return ret;

+       return cdns_update_config(cdns);

and remove the "ret" variable.

Yes, it's the same issue as previously reported. will fix.