-----"Anders Roxell" <[email protected]> wrote: -----
>To: [email protected], [email protected], [email protected] >From: "Anders Roxell" <[email protected]> >Date: 07/26/2019 11:26AM >Cc: [email protected], [email protected], "Anders >Roxell" <[email protected]> >Subject: [EXTERNAL] [PATCH] rdma: siw: remove unused variable > >The variable 'p' si no longer used and the compiler rightly complains >that it should be removed. > >../drivers/infiniband/sw/siw/siw_mem.c: In function ‘siw_free_plist’: >../drivers/infiniband/sw/siw/siw_mem.c:66:16: warning: unused >variable > ‘p’ [-Wunused-variable] > struct page **p = chunk->plist; > ^ > >Rework to remove unused variable. > >Fixes: 8288d030447f ("mm/gup: add make_dirty arg to >put_user_pages_dirty_lock()") >Signed-off-by: Anders Roxell <[email protected]> >--- > drivers/infiniband/sw/siw/siw_mem.c | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/drivers/infiniband/sw/siw/siw_mem.c >b/drivers/infiniband/sw/siw/siw_mem.c >index 358d440efa11..ab83a9cec562 100644 >--- a/drivers/infiniband/sw/siw/siw_mem.c >+++ b/drivers/infiniband/sw/siw/siw_mem.c >@@ -63,8 +63,6 @@ struct siw_mem *siw_mem_id2obj(struct siw_device >*sdev, int stag_index) > static void siw_free_plist(struct siw_page_chunk *chunk, int >num_pages, > bool dirty) > { >- struct page **p = chunk->plist; >- > put_user_pages_dirty_lock(chunk->plist, num_pages, dirty); > } > >-- >2.20.1 > > If we can cut down siw_free_plist() to just calling put_user_pages_dirty_lock(), we shall better call it directly and not obfuscate that by another function. Reviewed-by: Bernard Metzler <[email protected]>
