Hi,
On Tue, Jul 30, 2019 at 11:15:16AM -0700, Stephen Boyd wrote:
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
>
> // <smpl>
> @@
> expression ret;
> struct platform_device *E;
> @@
>
> ret =
> (
> platform_get_irq(E, ...)
> |
> platform_get_irq_byname(E, ...)
> );
>
> if ( \( ret < 0 \| ret <= 0 \) )
> {
> (
> -if (ret != -EPROBE_DEFER)
> -{ ...
> -dev_err(...);
> -... }
> |
> ...
> -dev_err(...);
> )
> ...
> }
> // </smpl>
>
> While we're here, remove braces on if statements that only have one
> statement (manually).
>
> Cc: Sebastian Reichel <s...@kernel.org>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Signed-off-by: Stephen Boyd <swb...@chromium.org>
> ---
>
> Please apply directly to subsystem trees
Thanks, queued to hsi-next.
-- Sebastian
>
> drivers/hsi/controllers/omap_ssi_core.c | 4 +---
> drivers/hsi/controllers/omap_ssi_port.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hsi/controllers/omap_ssi_core.c
> b/drivers/hsi/controllers/omap_ssi_core.c
> index 0cba567ee2d7..4bc4a201f0f6 100644
> --- a/drivers/hsi/controllers/omap_ssi_core.c
> +++ b/drivers/hsi/controllers/omap_ssi_core.c
> @@ -370,10 +370,8 @@ static int ssi_add_controller(struct hsi_controller *ssi,
> if (err < 0)
> goto out_err;
> err = platform_get_irq_byname(pd, "gdd_mpu");
> - if (err < 0) {
> - dev_err(&pd->dev, "GDD IRQ resource missing\n");
> + if (err < 0)
> goto out_err;
> - }
> omap_ssi->gdd_irq = err;
> tasklet_init(&omap_ssi->gdd_tasklet, ssi_gdd_tasklet,
> (unsigned long)ssi);
> diff --git a/drivers/hsi/controllers/omap_ssi_port.c
> b/drivers/hsi/controllers/omap_ssi_port.c
> index 2cd93119515f..a0cb5be246e1 100644
> --- a/drivers/hsi/controllers/omap_ssi_port.c
> +++ b/drivers/hsi/controllers/omap_ssi_port.c
> @@ -1038,10 +1038,8 @@ static int ssi_port_irq(struct hsi_port *port, struct
> platform_device *pd)
> int err;
>
> err = platform_get_irq(pd, 0);
> - if (err < 0) {
> - dev_err(&port->device, "Port IRQ resource missing\n");
> + if (err < 0)
> return err;
> - }
> omap_port->irq = err;
> err = devm_request_threaded_irq(&port->device, omap_port->irq, NULL,
> ssi_pio_thread, IRQF_ONESHOT, "SSI PORT", port);
> --
> Sent by a computer through tubes
>
signature.asc
Description: PGP signature
